feat!: deprecate Truncate component
#3336
Conversation
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alpha #3336 +/- ##
==========================================
- Coverage 93.82% 93.75% -0.07%
==========================================
Files 229 230 +1
Lines 3836 3862 +26
Branches 916 899 -17
==========================================
+ Hits 3599 3621 +22
- Misses 230 237 +7
+ Partials 7 4 -3 ☔ View full report in Codecov by Sentry. |
| @@ -66,4 +66,9 @@ Truncate.defaultProps = { | |||
| onTruncate: undefined, | |||
| }; | |||
|
|
|||
| function Truncate() { | |||
| return null; | |||
There was a problem hiding this comment.
[consideration] I wonder if it'd be worth having something like a console.log or similar here to give some output when this no-op component is used, e.g.
function Truncate() {
useEffect(() => {
console.log('Please use Truncate.Deprecated until a replacement is created');
}, []);
return null;
}
brian-smith-tcril
force-pushed
the
depr-truncate
branch
from
3678ea4 to
f781370
Compare
|
🎉 This PR is included in version 23.0.0-alpha.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 23.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
See #3311 (comment)
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
exampleapp?Post-merge Checklist